Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable Ruby crashtracking tests #2920

Merged
merged 2 commits into from
Sep 18, 2024
Merged

Conversation

TonyCTHsu
Copy link
Contributor

@TonyCTHsu TonyCTHsu commented Aug 26, 2024

Motivation

Enable Ruby's crashtracking tests

Changes

  1. Update protobuf for Ruby and Python
  2. Add crashtracking server implementation

Workflow

  1. ⚠️ Create your PR as draft ⚠️
  2. Work on you PR until the CI passes (if something not related to your task is failing, you can ignore it)
  3. Mark it as ready for review
    • Test logic is modified? -> Get a review from RFC owner. We're working on refining the codeowners file quickly.
    • Framework is modified, or non obvious usage of it -> get a review from R&P team

🚀 Once your PR is reviewed, you can merge it!

🛟 #apm-shared-testing 🛟

Reviewer checklist

  • If PR title starts with [<language>], double-check that only <language> is impacted by the change
  • No system-tests internal is modified. Otherwise, I have the approval from R&P team
  • CI is green, or failing jobs are not related to this change (and you are 100% sure about this statement)
  • A docker base image is modified?
    • the relevant build-XXX-image label is present
  • A scenario is added (or removed)?

@TonyCTHsu TonyCTHsu added the ruby Pull requests that update Ruby code label Aug 26, 2024
@TonyCTHsu TonyCTHsu marked this pull request as ready for review September 17, 2024 14:48
@TonyCTHsu TonyCTHsu requested review from Kyle-Verhoog and a team as code owners September 17, 2024 14:48
@TonyCTHsu TonyCTHsu requested review from ZStriker19 and removed request for a team September 17, 2024 14:48
@TonyCTHsu TonyCTHsu merged commit ca2d033 into main Sep 18, 2024
283 checks passed
@TonyCTHsu TonyCTHsu deleted the tonycthsu/ruby-crash-tracking branch September 18, 2024 08:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ruby Pull requests that update Ruby code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants