Skip to content

Conversation

@PerfectSlayer
Copy link
Contributor

@PerfectSlayer PerfectSlayer commented Aug 27, 2024

Motivation

This PR enables the crash tracking parametric tests for Java

Changes

Crash tracking related changes:

  • Handle /trace/crash endpoint
  • Enable crash trashing from run.sh script
  • Update documentation
  • Refactor controller to make room for root /trace controller
  • Add java specific crash report evaluation

Also include some clean up:

  • Update span links handling (clean up logging and simplify logic)
  • Add missing endpoint support (trace/otel/current_span, trace/span/set_resource)
  • Remove old gRPC configuration

Workflow

  1. ⚠️ Create your PR as draft ⚠️
  2. Work on you PR until the CI passes (if something not related to your task is failing, you can ignore it)
  3. Mark it as ready for review
    • Test logic is modified? -> Get a review from RFC owner. We're working on refining the codeowners file quickly.
    • Framework is modified, or non obvious usage of it -> get a review from R&P team

🚀 Once your PR is reviewed, you can merge it!

🛟 #apm-shared-testing 🛟

Reviewer checklist

  • If PR title starts with [<language>], double-check that only <language> is impacted by the change
  • No system-tests internal is modified. Otherwise, I have the approval from R&P team
  • CI is green, or failing jobs are not related to this change (and you are 100% sure about this statement)
  • A docker base image is modified?
    • the relevant build-XXX-image label is present
  • A scenario is added (or removed)?

APMLP-154

@PerfectSlayer PerfectSlayer force-pushed the bbujon/parametric-otel-java branch from bf21f7f to 3a7ac45 Compare August 28, 2024 07:19
@PerfectSlayer PerfectSlayer added the java Pull requests that update Java code label Aug 28, 2024
@PerfectSlayer PerfectSlayer changed the title Add crash tracking parametric test for Java [java] Add crash tracking parametric test for Java Aug 28, 2024
@PerfectSlayer PerfectSlayer force-pushed the bbujon/parametric-otel-java branch from ae29604 to ff1412b Compare August 28, 2024 11:29
@PerfectSlayer PerfectSlayer marked this pull request as ready for review August 28, 2024 12:26
@PerfectSlayer PerfectSlayer requested review from a team and Kyle-Verhoog as code owners August 28, 2024 12:26
@PerfectSlayer PerfectSlayer force-pushed the bbujon/parametric-otel-java branch from ff1412b to 5dbea4b Compare August 28, 2024 13:41
@cbeauchesne
Copy link
Collaborator

Updating the branch, a permission issue was preventing CI to start

@PerfectSlayer PerfectSlayer force-pushed the bbujon/parametric-otel-java branch from eb7c219 to a04e787 Compare August 29, 2024 08:11
@PerfectSlayer
Copy link
Contributor Author

cc @jbachorik as crash tracking implementer

Copy link
Contributor

@jbachorik jbachorik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good from the PoV of Java crash tracking.
Thanks for adding it to the system tests!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

java Pull requests that update Java code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants