-
Notifications
You must be signed in to change notification settings - Fork 14
[java] Add crash tracking parametric test for Java #2931
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bf21f7f to
3a7ac45
Compare
ae29604 to
ff1412b
Compare
ff1412b to
5dbea4b
Compare
Collaborator
|
Updating the branch, a permission issue was preventing CI to start |
eb7c219 to
a04e787
Compare
Contributor
Author
|
cc @jbachorik as crash tracking implementer |
jbachorik
reviewed
Aug 29, 2024
Contributor
jbachorik
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good from the PoV of Java crash tracking.
Thanks for adding it to the system tests!
cbeauchesne
approved these changes
Aug 29, 2024
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
This PR enables the crash tracking parametric tests for Java
Changes
Crash tracking related changes:
/trace/crashendpointrun.shscript/tracecontrollerAlso include some clean up:
trace/otel/current_span,trace/span/set_resource)Workflow
codeownersfile quickly.🚀 Once your PR is reviewed, you can merge it!
🛟 #apm-shared-testing 🛟
Reviewer checklist
[<language>], double-check that only<language>is impacted by the changebuild-XXX-imagelabel is presentAPMLP-154