Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[asm] add tests for session fingerprints #3005

Merged
merged 2 commits into from
Sep 18, 2024

Conversation

manuel-alvarez-alvarez
Copy link
Member

@manuel-alvarez-alvarez manuel-alvarez-alvarez commented Sep 10, 2024

Motivation

Include new session fingeprints in the tests.

Changes

Adds a new test to validate the generation of session fingerprints, it also updates the java springboot weblog with the new endpoint.

Workflow

  1. ⚠️ Create your PR as draft ⚠️
  2. Work on you PR until the CI passes (if something not related to your task is failing, you can ignore it)
  3. Mark it as ready for review
    • Test logic is modified? -> Get a review from RFC owner. We're working on refining the codeowners file quickly.
    • Framework is modified, or non obvious usage of it -> get a review from R&P team

🚀 Once your PR is reviewed, you can merge it!

🛟 #apm-shared-testing 🛟

Reviewer checklist

  • If PR title starts with [<language>], double-check that only <language> is impacted by the change
  • No system-tests internal is modified. Otherwise, I have the approval from R&P team
  • CI is green, or failing jobs are not related to this change (and you are 100% sure about this statement)
  • A docker base image is modified?
    • the relevant build-XXX-image label is present
  • A scenario is added (or removed)?

@simon-id
Copy link
Member

It doesn't validate the RC capability that goes with it no ?

@manuel-alvarez-alvarez
Copy link
Member Author

It doesn't validate the RC capability that goes with it no ?

No, not yet, none of the fingerprint RCs are validated, but my plan is to do another PR as soon as the RASP capabilities PR is merged.

@cbeauchesne
Copy link
Collaborator

I've updated your branch, to fix some CI failures

@manuel-alvarez-alvarez manuel-alvarez-alvarez force-pushed the malvarez/waf-session-fingerprint branch 2 times, most recently from e782954 to 3a33aca Compare September 17, 2024 14:36
@manuel-alvarez-alvarez manuel-alvarez-alvarez merged commit c60bd10 into main Sep 18, 2024
380 of 386 checks passed
@manuel-alvarez-alvarez manuel-alvarez-alvarez deleted the malvarez/waf-session-fingerprint branch September 18, 2024 10:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants