Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

go: add Go test app for profiling SSI #3058

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

nsrip-dd
Copy link
Contributor

TODO - description

Motivation

Changes

Workflow

  1. ⚠️ Create your PR as draft ⚠️
  2. Work on you PR until the CI passes (if something not related to your task is failing, you can ignore it)
  3. Mark it as ready for review
    • Test logic is modified? -> Get a review from RFC owner. We're working on refining the codeowners file quickly.
    • Framework is modified, or non obvious usage of it -> get a review from R&P team

🚀 Once your PR is reviewed, you can merge it!

🛟 #apm-shared-testing 🛟

Reviewer checklist

  • If PR title starts with [<language>], double-check that only <language> is impacted by the change
  • No system-tests internal is modified. Otherwise, I have the approval from R&P team
  • CI is green, or failing jobs are not related to this change (and you are 100% sure about this statement)
  • A docker base image is modified?
    • the relevant build-XXX-image label is present
  • A scenario is added (or removed)?

@nsrip-dd nsrip-dd force-pushed the nick.ripley/add-go-orchestrion-profiling-test branch 7 times, most recently from b16a6fe to c6d72d9 Compare September 18, 2024 17:39
@nsrip-dd nsrip-dd force-pushed the nick.ripley/add-go-orchestrion-profiling-test branch from c6d72d9 to 2720aa5 Compare October 9, 2024 15:54
Go doesn't use "SSI", i.e. run-time instrumentation, but it does have
automatic instrumentation at compile time via Orchestrion. Add tests for
that similar to the SSI one for other languages, where we run an
instrumented HTTP server application and check that we generate traces
and profiles and that they make it through our full processing pipeline.

We need some kludges to make sure this stuff works for Go. We don't have
"golang" injection for the agent installer, and the script fails if we
try to run it, so we tell the installer script we're "java" just to make
it complete.
@nsrip-dd nsrip-dd force-pushed the nick.ripley/add-go-orchestrion-profiling-test branch from 2720aa5 to a602e7e Compare October 9, 2024 15:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant