Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

config_consistency: Enable tests for the python and ruby tracers #3078

Open
wants to merge 9 commits into
base: main
Choose a base branch
from
Open

config_consistency: Enable tests for the python and ruby tracers #3078

wants to merge 9 commits into from

Conversation

mabdinur
Copy link
Contributor

@mabdinur mabdinur commented Sep 19, 2024 •
edited
Loading

Motivation

  • Enables all python and ruby config consistency tests that are XPassing.

Workflow

  1. ⚠️ Create your PR as draft ⚠️
  2. Work on you PR until the CI passes (if something not related to your task is failing, you can ignore it)
  3. Mark it as ready for review
    • Test logic is modified? -> Get a review from RFC owner. We're working on refining the codeowners file quickly.
    • Framework is modified, or non obvious usage of it -> get a review from R&P team

🚀 Once your PR is reviewed, you can merge it!

🛟 #apm-shared-testing 🛟

Reviewer checklist

  • If PR title starts with [<language>], double-check that only <language> is impacted by the change
  • No system-tests internal is modified. Otherwise, I have the approval from R&P team
  • CI is green, or failing jobs are not related to this change (and you are 100% sure about this statement)
  • A docker base image is modified?
    • the relevant build-XXX-image label is present
  • A scenario is added (or removed)?

@mabdinur mabdinur changed the title config_consistency: Enable all XPassing tests config_consistency: Enable python XPassing tests Sep 20, 2024
@mabdinur mabdinur changed the title config_consistency: Enable python XPassing tests config_consistency: Enable XPassing tests Sep 20, 2024
mabdinur
mabdinur commented Sep 20, 2024
View reviewed changes
manifests/nodejs.yml Outdated Show resolved Hide resolved
mabdinur
mabdinur commented Sep 20, 2024
View reviewed changes
manifests/php.yml Outdated Show resolved Hide resolved
mabdinur
mabdinur commented Sep 20, 2024
View reviewed changes
manifests/nodejs.yml Outdated Show resolved Hide resolved
@mabdinur mabdinur force-pushed the munir/enable-passing-config-tests branch from 60a67fd to eac24d3 Compare September 20, 2024 17:39
@mabdinur mabdinur changed the title config_consistency: Enable XPassing tests config_consistency: Enable Passing Config_UnifiedServiceTagging_CustomService tests Sep 20, 2024
@mabdinur mabdinur marked this pull request as ready for review September 20, 2024 17:41
@mabdinur mabdinur requested review from a team as code owners September 20, 2024 17:41
@mabdinur mabdinur requested review from lievan and wconti27 and removed request for a team September 20, 2024 17:41
@mabdinur mabdinur requested review from smola, jandro996 and dmehala and removed request for a team September 20, 2024 17:41
@mabdinur mabdinur marked this pull request as draft September 20, 2024 17:53
@mabdinur mabdinur changed the title config_consistency: Enable Passing Config_UnifiedServiceTagging_CustomService tests config_consistency: Enable tests for the python and ruby tracers Sep 20, 2024
mabdinur
mabdinur commented Sep 20, 2024
View reviewed changes
manifests/cpp.yml Outdated Show resolved Hide resolved
mabdinur
mabdinur commented Sep 20, 2024
View reviewed changes
manifests/dotnet.yml Outdated Show resolved Hide resolved
mabdinur
mabdinur commented Sep 20, 2024
View reviewed changes
manifests/golang.yml Outdated Show resolved Hide resolved
mabdinur
mabdinur commented Sep 20, 2024
View reviewed changes
manifests/java.yml Outdated Show resolved Hide resolved
mabdinur
mabdinur commented Sep 20, 2024
View reviewed changes
manifests/nodejs.yml Outdated Show resolved Hide resolved
mabdinur
mabdinur commented Sep 20, 2024
View reviewed changes
manifests/php.yml Outdated Show resolved Hide resolved
@mabdinur mabdinur marked this pull request as ready for review September 20, 2024 20:38
@mabdinur mabdinur requested review from Kyle-Verhoog and a team as code owners September 20, 2024 20:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lievan lievan Awaiting requested review from lievan lievan is a code owner automatically assigned from DataDog/apm-python

@wconti27 wconti27 Awaiting requested review from wconti27 wconti27 is a code owner automatically assigned from DataDog/apm-python

@smola smola Awaiting requested review from smola smola was automatically assigned from DataDog/asm-java

@jandro996 jandro996 Awaiting requested review from jandro996 jandro996 was automatically assigned from DataDog/asm-java

@dmehala dmehala Awaiting requested review from dmehala dmehala was automatically assigned from DataDog/dd-trace-cpp

@Kyle-Verhoog Kyle-Verhoog Awaiting requested review from Kyle-Verhoog Kyle-Verhoog is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@mabdinur