Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enabling Already Consistent .NET Tests #3087

Merged
merged 7 commits into from
Sep 20, 2024
Merged

Enabling Already Consistent .NET Tests #3087

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
a70ca11
Enabling UnifiedServiceTagging passing tests
link04 Sep 18, 2024
b8a88c3
Changed to check consistent telemetry directly by env var
link04 Sep 18, 2024
47dd2b2
Running ./format.sh
link04 Sep 18, 2024
8196056
Merge branch 'maximo/config-consistency-telemetry-test-update' into m…
link04 Sep 19, 2024
99d5e99
Merge branch 'main' into maximo/enabling-consistent-dotnet-configs
link04 Sep 19, 2024
3f17261
Enabling all currently passing tests
link04 Sep 20, 2024
cccdc99
Merge branch 'main' into maximo/enabling-consistent-dotnet-configs
link04 Sep 20, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 7 additions & 7 deletions manifests/dotnet.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -317,9 +317,9 @@ tests/:
TestAdmisionControllerProfiling: missing_feature
parametric/:
test_config_consistency.py:
Test_Config_TraceEnabled: missing_feature
Test_Config_TraceLogDirectory: missing_feature
Test_Config_UnifiedServiceTagging: missing_feature
Test_Config_TraceEnabled: v3.3.0
Test_Config_TraceLogDirectory: v3.3.0
Test_Config_UnifiedServiceTagging: v3.3.0
test_crashtracking.py:
Test_Crashtracking: v3.2.0
test_dynamic_configuration.py:
Expand Down Expand Up @@ -369,16 +369,16 @@ tests/:
test_miscs.py:
Test_Miscs: missing_feature
test_config_consistency.py:
Test_Config_ClientIPHeader_Configured: v2.48.0
Test_Config_ClientIPHeader_Configured: missing_feature (Not actually passing telemetry test so disabling until I do)
Test_Config_ClientIPHeader_Precedence: missing_feature (all headers listed in the RFC are not supported)
Test_Config_ClientTagQueryString_Configured: missing_feature (configuration DNE)
Test_Config_ClientTagQueryString_Empty: v2.53.0
Test_Config_ClientTagQueryString_Empty: missing_feature (Not actually passing telemetry test so disabling until I do)
Test_Config_HttpClientErrorStatuses_Default: missing_feature
Test_Config_HttpClientErrorStatuses_FeatureFlagCustom: missing_feature
Test_Config_HttpServerErrorStatuses_Default: missing_feature
Test_Config_HttpServerErrorStatuses_FeatureFlagCustom: missing_feature
Test_Config_UnifiedServiceTagging_CustomService: missing_feature
Test_Config_UnifiedServiceTagging_Default: missing_feature
Test_Config_UnifiedServiceTagging_CustomService: v3.3.0
Test_Config_UnifiedServiceTagging_Default: v3.3.0
test_data_integrity.py:
Test_LibraryHeaders: v2.46.0
test_distributed.py:
Expand Down
2 changes: 1 addition & 1 deletion utils/build/docker/dotnet/parametric/Endpoints/ApmTestApi.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -129,7 +129,7 @@ private static async Task<string> StartSpan(HttpRequest request)
using var scope = Tracer.Instance.StartActive(operationName: name!.ToString()!, creationSettings);
var span = scope.Span;

if (parsedDictionary.TryGetValue("service", out var service))
if (parsedDictionary.TryGetValue("service", out var service) && !String.IsNullOrEmpty(service.ToString()))
{
span.ServiceName = service.ToString();
}
Expand Down
Loading