Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

parametric: move make_single_request_and_get_inject_headers to APMLibrary #3512

Merged
merged 6 commits into from
Nov 22, 2024

Conversation

mabdinur
Copy link
Contributor

@mabdinur mabdinur commented Nov 20, 2024

Motivation

  • Provide a single interface for interacting with Parametric apps (APMLibrary)

Changes

  • Moves make_single_request_and_get_inject_headers from utils/parametric/headers.py to APMLibrary
  • Renames make_single_request_and_get_inject_headers to dd_make_child_span_and_get_headers
  • Removes utils/parametric/headers.py
  • Renames extract_headers_and_make_child_span to dd_extract_headers_and_make_child_span

Workflow

  1. ⚠️ Create your PR as draft ⚠️
  2. Work on you PR until the CI passes (if something not related to your task is failing, you can ignore it)
  3. Mark it as ready for review
    • Test logic is modified? -> Get a review from RFC owner. We're working on refining the codeowners file quickly.
    • Framework is modified, or non obvious usage of it -> get a review from R&P team

🚀 Once your PR is reviewed, you can merge it!

🛟 #apm-shared-testing 🛟

Reviewer checklist

  • If PR title starts with [<language>], double-check that only <language> is impacted by the change
  • No system-tests internal is modified. Otherwise, I have the approval from R&P team
  • CI is green, or failing jobs are not related to this change (and you are 100% sure about this statement)
  • A docker base image is modified?
    • the relevant build-XXX-image label is present
  • A scenario is added (or removed)?

@mabdinur mabdinur requested a review from cbeauchesne November 20, 2024 18:53
@mabdinur mabdinur force-pushed the move-http-header-helper-to-library-interface branch from 2023b29 to fe93987 Compare November 21, 2024 21:19
@mabdinur mabdinur marked this pull request as ready for review November 21, 2024 21:20
@mabdinur mabdinur requested review from a team as code owners November 21, 2024 21:20
@mabdinur mabdinur requested review from cecile75 and khanayan123 and removed request for a team November 21, 2024 21:20
@mabdinur mabdinur requested review from a team as code owners November 22, 2024 16:33
@mabdinur mabdinur removed the request for review from a team November 22, 2024 16:33
@mabdinur mabdinur requested review from gnufede, P403n1x87, smola, ValentinZakharov and Anilm3 and removed request for a team November 22, 2024 16:33
@mabdinur mabdinur force-pushed the move-http-header-helper-to-library-interface branch from 1a2095c to f19a9ce Compare November 22, 2024 17:42
@mabdinur mabdinur merged commit 9c26730 into main Nov 22, 2024
289 checks passed
@mabdinur mabdinur deleted the move-http-header-helper-to-library-interface branch November 22, 2024 19:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants