Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Java][parametric] add OpenTracing and OpenTelemetry baggage endpoints #3535

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

lucaspimentel
Copy link
Member

Motivation

Changes

Workflow

  1. ⚠️ Create your PR as draft ⚠️
  2. Work on you PR until the CI passes (if something not related to your task is failing, you can ignore it)
  3. Mark it as ready for review
    • Test logic is modified? -> Get a review from RFC owner. We're working on refining the codeowners file quickly.
    • Framework is modified, or non obvious usage of it -> get a review from R&P team

🚀 Once your PR is reviewed, you can merge it!

🛟 #apm-shared-testing 🛟

Reviewer checklist

  • If PR title starts with [<language>], double-check that only <language> is impacted by the change
  • No system-tests internal is modified. Otherwise, I have the approval from R&P team
  • CI is green, or failing jobs are not related to this change (and you are 100% sure about this statement)
  • A docker base image is modified?
    • the relevant build-XXX-image label is present
  • A scenario is added (or removed)?

@lucaspimentel lucaspimentel added the java Pull requests that update Java code label Nov 22, 2024
@@ -58,11 +44,13 @@ public class OpenTelemetryController {
private final Tracer tracer;
private final TextMapPropagator propagator;
private final Map<Long, Span> spans;
private Baggage baggage;
Copy link
Member Author

@lucaspimentel lucaspimentel Nov 22, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With Spring, does this baggage persist across multiple requests to the same controller? In the built-in .NET MVC frameworks, a new controller instance is created for each request, so we make them static members in the test apps:

private static readonly Dictionary<ulong, ISpan> Spans = new();
private static readonly Dictionary<ulong, Datadog.Trace.ISpanContext> DDContexts = new();

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
java Pull requests that update Java code run-parametric-scenario
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant