Skip to content

Avoid false XPASS on APPSEC_WAF_TELEMETRY #4029

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
smola merged 1 commit into from
Feb 10, 2025
Merged

Avoid false XPASS on APPSEC_WAF_TELEMETRY #4029

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion tests/appsec/waf/test_telemetry.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,9 @@ class Test_TelemetryMetrics:
@bug(context.library < "java@1.13.0", reason="APMRP-360")
def test_headers_are_correct(self):
"""Tests that all telemetry requests have correct headers."""
for data in interfaces.library.get_telemetry_data(flatten_message_batches=False):
datas = list(interfaces.library.get_telemetry_data(flatten_message_batches=False))
assert len(datas) > 0, "No telemetry received"
for data in datas:
request_type = data["request"]["content"].get("request_type")
_validate_headers(data["request"]["headers"], request_type)

Expand Down