Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[java] Fix tag_value endpoint in for JSON body #4211

Merged
merged 1 commit into from
Feb 28, 2025

Conversation

smola
Copy link
Member

@smola smola commented Feb 27, 2025

Motivation

The tag_value endpoint must accept urlencoded forms and JSON. In spring-boot and akka-http it did not support JSON, which broke the corresponding API Security tests.

akka-http still does not pass the test, but spring-boot does.

Changes

Workflow

  1. ⚠️ Create your PR as draft ⚠️
  2. Work on you PR until the CI passes (if something not related to your task is failing, you can ignore it)
  3. Mark it as ready for review
    • Test logic is modified? -> Get a review from RFC owner. We're working on refining the codeowners file quickly.
    • Framework is modified, or non obvious usage of it -> get a review from R&P team

🚀 Once your PR is reviewed, you can merge it!

🛟 #apm-shared-testing 🛟

Reviewer checklist

  • If PR title starts with [<language>], double-check that only <language> is impacted by the change
  • No system-tests internal is modified. Otherwise, I have the approval from R&P team
  • CI is green, or failing jobs are not related to this change (and you are 100% sure about this statement)
  • A docker base image is modified?
    • the relevant build-XXX-image label is present
  • A scenario is added (or removed)?

@smola smola force-pushed the smola/springboot-tagvalue-json branch from 6554dfe to 8c136b9 Compare February 28, 2025 10:23
@smola smola marked this pull request as ready for review February 28, 2025 10:52
@smola smola requested review from a team as code owners February 28, 2025 10:52
@smola smola enabled auto-merge (squash) February 28, 2025 10:52
@smola smola merged commit f93fa72 into main Feb 28, 2025
55 checks passed
@smola smola deleted the smola/springboot-tagvalue-json branch February 28, 2025 11:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants