Skip to content

Conversation

@MattAlp
Copy link

@MattAlp MattAlp commented Apr 22, 2025

Motivation

This is required for DataDog/dd-trace-java#8718 to pass CI, which adds some additional telemetry intended to provide a more comprehensive picture of some of the modules un/available on the JVMs we instrument.

Changes

Adds one additional allowed regex pattern for emitted logs.

Workflow

  1. ⚠️ Create your PR as draft ⚠️
  2. Work on you PR until the CI passes (if something not related to your task is failing, you can ignore it)
  3. Mark it as ready for review
    • Test logic is modified? -> Get a review from RFC owner. We're working on refining the codeowners file quickly.
    • Framework is modified, or non obvious usage of it -> get a review from R&P team

🚀 Once your PR is reviewed, you can merge it!

🛟 #apm-shared-testing 🛟

Reviewer checklist

  • If PR title starts with [<language>], double-check that only <language> is impacted by the change
  • No system-tests internal is modified. Otherwise, I have the approval from R&P team
  • CI is green, or failing jobs are not related to this change (and you are 100% sure about this statement)
  • A docker base image is modified?
    • the relevant build-XXX-image label is present
  • A scenario is added (or removed)?

@MattAlp MattAlp requested a review from a team as a code owner April 22, 2025 19:18
@MattAlp MattAlp merged commit 9b44040 into main Apr 23, 2025
1363 of 1365 checks passed
@MattAlp MattAlp deleted the mattalp/add-jvmstat-related-telemetry-override branch April 23, 2025 14:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants