Skip to content

Conversation

@christophe-papazian
Copy link
Contributor

@christophe-papazian christophe-papazian commented Nov 6, 2025

Motivation

Once DataDog/dd-trace-py#15042 is merged, tests for that new feature can be enabled.

APPSEC-59798

Workflow

  1. ⚠️ Create your PR as draft ⚠️
  2. Work on you PR until the CI passes
  3. Mark it as ready for review
    • Test logic is modified? -> Get a review from RFC owner.
    • Framework is modified, or non obvious usage of it -> get a review from R&P team

🚀 Once your PR is reviewed and the CI green, you can merge it!

🛟 #apm-shared-testing 🛟

Reviewer checklist

  • If PR title starts with [<language>], double-check that only <language> is impacted by the change
  • No system-tests internal is modified. Otherwise, I have the approval from R&P team
  • A docker base image is modified?
    • the relevant build-XXX-image label is present
  • A scenario is added (or removed)?

@github-actions
Copy link
Contributor

github-actions bot commented Nov 6, 2025

CODEOWNERS have been resolved as:

manifests/python.yml                                                    @DataDog/apm-python @DataDog/asm-python

christophe-papazian added a commit to DataDog/dd-trace-py that referenced this pull request Nov 7, 2025
## Description

- new blocking id feature
- libddwaf update (required for this feature)
- refactor of blocking configuration with dedicated type
- tests updated
- will also be validated by system tests
DataDog/system-tests#5674

APPSEC-59798
@christophe-papazian christophe-papazian marked this pull request as ready for review November 7, 2025 10:07
@christophe-papazian christophe-papazian requested review from a team as code owners November 7, 2025 10:07
@christophe-papazian christophe-papazian requested review from gnufede and juanjux and removed request for a team November 7, 2025 10:07
@christophe-papazian christophe-papazian merged commit 43c7681 into main Nov 7, 2025
45 checks passed
@christophe-papazian christophe-papazian deleted the christophe-papazian/enable_security_response_id branch November 7, 2025 10:09
emmettbutler pushed a commit to DataDog/dd-trace-py that referenced this pull request Nov 7, 2025
- new blocking id feature
- libddwaf update (required for this feature)
- refactor of blocking configuration with dedicated type
- tests updated
- will also be validated by system tests
DataDog/system-tests#5674

APPSEC-59798
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants