[bug] Deleting monitors that are part of an SLO fails

[Towerthousand]

Hey!

Declaring a monitor and using it in a declared SLO and then removing the monitor (also removing it from the SLO in the same apply, of course) fails with an API error. There should be a check to remove it from all SLOs first or to remove it from the SLO automatically on deletion.

Happy to open a PR if pointed in the right direction. Thanks!

Terraform Version

Terraform v0.12.23
+ provider.datadog v2.7.0

Affected Resource(s)

• datadog_monitor
• datadog_service_level_objective

Terraform Configuration Files

Version 1:

datadog_monitor "this" {
  [...]
}
datadog_monitor "that" {
  [...]
}

resource datadog_service_level_objective "overrall_slo" {
  type = "monitor"
  monitor_ids = [datadog_monitor.this.id, datadog_monitor.that.id]
  [...]
}

Version 2:

datadog_monitor "this" {
  [...]
}

resource datadog_service_level_objective "overrall_slo" {
  type = "monitor"
  monitor_ids = [datadog_monitor.this.id]
  [...]
}

Debug Output

Error: API error 401 Unauthorized: {"errors":["monitor [16195606,test monitor 'this'] is referenced in slos: [34dbd856b8c8591dae09f9db0458adb2,test slo]"]}

Expected Behavior

Apply runs without errors

Actual Behavior

Apply errored with a 401, monitors and SLO untouched.

Steps to Reproduce

Please list the steps required to reproduce the issue, for example:

1. terraform apply with V1
2. terraform apply with V2

[Towerthousand]

Datadog API explicitly supports the force flag for this, but the go client does not support it

[Towerthousand]

I opened a PR on the go client: zorkian/go-datadog-api#311

[nmuesch]

Hey @Towerthousand Thanks for the report and the pull request to the go client. Would you be interested in working on adding this to the terraform provider?

@bkabrda updated the vendored go client in this provider that includes your change - https://github.com/terraform-providers/terraform-provider-datadog/pull/447/files

[Towerthousand]

Hey! adding a PR :)

[Towerthousand]

fixed in #535