Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use ForceDeleteMonitor instead of DeleteMonitor #451

Closed
wants to merge 1 commit into from

Conversation

Towerthousand
Copy link

This implements #439

@ghost ghost added the size/XS label Mar 17, 2020
@platinummonkey
Copy link
Contributor

I think I would prefer this to be somehow configurable. This is there to protect accidental deletes of resources (monitors in this case) that might be referenced in: dashboard widgets and SLOs for example.

@nmuesch
Copy link
Contributor

nmuesch commented Mar 20, 2020

@Towerthousand Thanks for this PR! To @platinummonkey's point, I think it would be helpful to maybe add an element to the schema so that users would explicitly be choosing to force delete their monitors and not have any accidental deletions?

I imagine the workflow in this case being, a user tries to delete a monitor without the force field set, and if its used somewhere they'd get a failure message with the monitor not deleted. Then, if it's really intended to delete, the force flag would be added to the schema with a terraform apply to store it in the state. Then remove the monitor and run another apply.
Though I'm not sure if this field can be read from the state from within the delete call?

@Towerthousand
Copy link
Author

fixed in #535

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants