Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Generated client v2 API #477

Merged
merged 11 commits into from
Apr 29, 2020
Merged

Add Generated client v2 API #477

merged 11 commits into from
Apr 29, 2020

Conversation

skarimo
Copy link
Member

@skarimo skarimo commented Apr 23, 2020

This PR adds Generate go client V2 api to the Terraform provider

@ghost ghost added the size/M label Apr 23, 2020
Copy link
Contributor

@zippolyte zippolyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

datadog/provider.go Outdated Show resolved Hide resolved
datadog/provider_test.go Outdated Show resolved Hide resolved
datadog/provider.go Outdated Show resolved Hide resolved
datadog/provider.go Outdated Show resolved Hide resolved
@ghost ghost added size/L and removed size/M labels Apr 24, 2020
datadog/provider.go Outdated Show resolved Hide resolved
datadog/provider.go Outdated Show resolved Hide resolved
Copy link
Contributor

@gzussa gzussa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch regarding the v2 client :)

return fmt.Errorf(msg+": %s", err.Error())
}

func translateClientErrorV2(err error, msg string) error {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not have everything in one method?

@gzussa gzussa merged commit 77ebc54 into DataDog:gzu/client Apr 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants