Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update monitor resource to use Datadog Go client #485

Merged
merged 7 commits into from
Apr 30, 2020
Merged

Update monitor resource to use Datadog Go client #485

merged 7 commits into from
Apr 30, 2020

Conversation

skarimo
Copy link
Member

@skarimo skarimo commented Apr 29, 2020 •
edited by gzussa
Loading

Updates monitor to use Datadog GO client.

Notes:

  • The tests were updated to remove trailing zeroes during assertions. This is ok since we already have suppressDataDogFloatIntDiff method making sure value match as float. Precision is not effected. Only trailing zeroes

@ghost ghost added the size/XL label Apr 29, 2020
@gzussa gzussa changed the base branch from gzu/client to master April 29, 2020 14:17
@gzussa
Copy link
Contributor

gzussa commented Apr 29, 2020

Let's hold off on this one for now.

@ghost ghost added size/L and removed size/XL labels Apr 29, 2020
@ghost ghost added size/XXL and removed size/L labels Apr 30, 2020
@gzussa gzussa merged commit eb4db12 into DataDog:master Apr 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
size/XXL
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@skarimo @gzussa