Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request] Support all options exposed by datadog_integration_pagerduty before it's removal #665

Closed
cooperbenson-qz opened this issue Sep 16, 2020 · 4 comments · Fixed by #930

Comments

@cooperbenson-qz
Copy link

cooperbenson-qz commented Sep 16, 2020

Terraform Version

Terraform v0.13.2
+ provider registry.terraform.io/terraform-providers/datadog v2.13.0
+ provider registry.terraform.io/terraform-providers/pagerduty v1.7.10

Affected Resource(s)

  • datadog_integration_pagerduty

Terraform Configuration Files

resource "datadog_integration_pagerduty" "integration" {
  subdomain           = var.pagerduty_subdomain
  individual_services = true
  api_token           = var.pagerduty_token
  schedules = [
    for schedule_id in var.schedule_ids :
    "https://${var.pagerduty_subdomain}.pagerduty.com/schedules/${schedule_id}"
  ]
}

Issue

The configuration above is producing a warning:

Warning: This resource is deprecated. You can use datadog_integration_pagerduty_service_object resources directly once the integration is activated

  on ../../modules/pagerduty_datadog_integration/main.tf line 14, in resource "datadog_integration_pagerduty" "integration":
  14: resource "datadog_integration_pagerduty" "integration" {

This is somewhat worrying since datadog_integration_pagerduty_service_object does not provide the ability to configure Pagerduty schedules which is something we rely upon. I understand the reasons for the deprecation, but this warning is unfixable for us because we rely on functionality that is only exposed by the deprecated resource. Would it make sense to add another resource like datadog_integration_pagerduty_schedule to configure the schedule mapping?

References

@JordanP
Copy link
Contributor

JordanP commented Oct 13, 2020

Hey, I am also using the schedules attribute of the datadog_integration_pagerduty resource. What's the new way of doing that ?

@therve
Copy link
Contributor

therve commented Feb 1, 2021

Hello,

Sorry for not answering earlier. I talked to the pagerduty integration team, and the current approach using webhooks should only require configuring service objects. Schedules are a pagerduty resource, so should be configured in pagerduty itself.

Can you confirm that it would work for you? Thanks.

@cooperbenson-qz
Copy link
Author

cooperbenson-qz commented Feb 3, 2021

My understanding is that the schedules are provided to Datadog to show who's on call in the event stream

Show who is on-call in your event stream: If you would like to view your PagerDuty on-call schedules in your Datadog event stream, you will need to retrieve the PagerDuty schedule URL. In PagerDuty, navigate to the Configuration menu and select Schedules, then click your desired schedule and copy its URL, which should look like this: https://YOURSUBDOMAIN.pagerduty.com/schedules#PXXXXXX. In Datadog, paste this into the Schedule URL field.

From Pagerduty's documentation

@therve
Copy link
Contributor

therve commented Feb 17, 2021

Hi,

This was an oversight apparently. We need a new API to manage schedules, in the mean time we'll undeprecate the resource. Thanks for your patience.

therve added a commit that referenced this issue Feb 17, 2021
Until we have a way to manage schedules to appear in the event stream,
this is still required.

Closes #665
therve added a commit that referenced this issue Feb 17, 2021
Until we have a way to manage schedules to appear in the event stream,
this is still required.

Closes #665
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants