Allow new_host_delay to be unset #101
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
masci
suggested changes
Oct 1, 2018
datadog/resource_datadog_monitor.go
Outdated
| if attr, ok := d.GetOk("new_host_delay"); ok { | ||
| o.SetNewHostDelay(attr.(int)) | ||
| } | ||
| NewHostDelay := d.Get("new_host_delay") |
There was a problem hiding this comment.
style nit: s/NewHostDelay/newHostDelay
masci
suggested changes
Oct 1, 2018
datadog/resource_datadog_monitor.go
Outdated
| o.SetNewHostDelay(attr.(int)) | ||
| } | ||
| newHostDelay := d.Get("new_host_delay") | ||
| o.SetNewHostDelay(NewHostDelay.(int)) |
masci
approved these changes
Oct 1, 2018
nitrocode
pushed a commit
to nitrocode/terraform-provider-datadog
that referenced
this pull request
Nov 3, 2018
Allow new_host_delay to be unset
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stops using the
GetOkmethod when updating the monitor struct for thenew_host_delayparameter.The GetOk method does a check both to see if the key is specified in the schema configuration AND is not the golang zero value for that type. So Using the GetOk function, specifying a
new_host_delay: 0would actually cause the default to be used.It seems like GetOk shouldn't be used for an int type that has a default value if
0is an allowed value for that key.Get-ing the key (the change introduced in this PR), you can specify a 0 value to mean
0or specify no value to fallback to the default.Alternatively, we could use the
GetOkExistsfunction, but that is only available starting with Terraform 0.10.1 and this provider currently pins the helpers library at 0.10.0