Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Google Cloud Platform integration #108

Merged
merged 4 commits into from
Oct 31, 2018

Conversation

dragon3
Copy link
Contributor

@dragon3 dragon3 commented Oct 20, 2018

This pull request is for #107 , adds Google Cloud Platform integration.

@ghost ghost added the size/XXL label Oct 20, 2018
@masci masci added this to the 1.5.0 milestone Oct 26, 2018
@masci
Copy link
Contributor

masci commented Oct 29, 2018

Can you rebase your change on master? I've updated a bunch of vendored dependencies, sorry for the hassle I should've merged your work before.

@dragon3
Copy link
Contributor Author

dragon3 commented Oct 29, 2018

No problem 👍
I've just rebased my change on master. Could you please check it?

Thank you!

@masci
Copy link
Contributor

masci commented Oct 31, 2018

Thanks for this, will merge and release asap with 1.5!

@masci masci merged commit 5eb50ea into DataDog:master Oct 31, 2018
@dragon3 dragon3 deleted the add-gcp-integration branch October 31, 2018 14:05
@dragon3
Copy link
Contributor Author

dragon3 commented Oct 31, 2018

Thank you!

nitrocode pushed a commit to nitrocode/terraform-provider-datadog that referenced this pull request Nov 3, 2018
Add Google Cloud Platform integration
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants