Support Synthetics tests in composite monitors #222
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
gabsn
commented
Jun 3, 2019
bkabrda
suggested changes
Jun 4, 2019
There was a problem hiding this comment.
Two minor nits to address (no changelog entry and updating the client library dep) and this can be merged. Great work, thanks for submitting this 👍
You'll also need to rebase because of other PR that was merged that changed go.sum; please squash all the commits into a single one while doing this to keep history clean.
bkabrda
approved these changes
Jun 6, 2019
jbenais
pushed a commit
to jbenais/terraform-provider-datadog
that referenced
this pull request
Aug 20, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please do not merge this PR until the PR on go-datadog-api is merged.