Suppress diff on default precision #228
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
jbenais
pushed a commit
to jbenais/terraform-provider-datadog
that referenced
this pull request
Aug 20, 2019
Suppress diff on default precision
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Suppress the diff on the precision attribute of timeboard graphs when it makes sense.
Some widget types allow the
precisionfield to be set. The default value for this is2. If the value isn't set in the config, the Datadog API applies a value of2on certain widget types (mainly query value widgets)Since the state has a
2returned by the API, it doesn't match the config value of"", causing a diff. We could provide this as a default to the schema, but its not a valid attribute to all graph widgets, so its cleaner to suppress the diff in this case.