Fix several integration tests and related code #234
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
nmuesch
reviewed
Jun 12, 2019
There was a problem hiding this comment.
Overall looks good! Thanks for fixing up these 💜 Couple of small questions
For the float -> int thing. We're just changing the test here, that one time diff would still happen before these changes right? If thats the case I don't think we need to call it out in the changelog.
Closed
|
Yeah, you're probably right about that one-time diff, so let's not put it into the changelog. |
nmuesch
reviewed
Jun 13, 2019
* Set datadog_downtime.timezone attribute in resourceDatadogDowntimeRead,
handle it in import test
* Make datadog_downtime.tags a TypeSet to be able to properly ignore
differences in ordering of its contents
* Fix two regressions caused by calling resourceDatadogMonitorRead from
resourceDatadogMonitorUpdate and resourceDatadogMonitorCreate:
* Make sure that API sometimes changing "metric alert" to "query alert"
continues to be ignored
* Fix tests for threshold values to always expect floats
|
Thanks for the review! Merging. |
jbenais
pushed a commit
to jbenais/terraform-provider-datadog
that referenced
this pull request
Aug 20, 2019
Fix several integration tests and related code
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
handle it in import test
differences in ordering of its contents
resourceDatadogMonitorUpdate and resourceDatadogMonitorCreate:
continues to be ignored
The last change should be mentioned in the changelog, because that will actually create a non-empty plan for people who have used integers as values for thresholds previously - with next apply, these are all going to change to floats (one-time only). It's not really a regression, since the values will just change their type, but still noteworthy IMO.