Fix up the GCP and User tests #238
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
bkabrda
approved these changes
Jun 17, 2019
jbenais
pushed a commit
to jbenais/terraform-provider-datadog
that referenced
this pull request
Aug 20, 2019
* Update and fix tests * Remove the extra log lines
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes up the last two integration tests as of this writing:
TestAccDatadogIntegrationGCP and TestAccDatadogUser_Updated
Neither of these tests were inherently broken, just needed some coercion to play nicely with the CI
GCP:
The project drifted a bit from the CI but is difficult to fix with limited access. This should address that for now while working on a longer term solution
User:
A user may only edit their own email via the API, not someone elses. The CI DD account likely has a
test@user in the org. However this doesn't play nicely with running the integration tests locally. This uses a random user email so we get the same test behavior both on the CI and locally.