Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor and add tests + cassettes #539

Merged
merged 12 commits into from
Jun 19, 2020
Merged

refactor and add tests + cassettes #539

merged 12 commits into from
Jun 19, 2020

Conversation

gzussa
Copy link
Contributor

@gzussa gzussa commented Jun 15, 2020 •
edited
Loading

Fix: set title and title_align properly on heatmap widget

@gzussa gzussa added the do-not-merge/WIP Do not merge this PR label Jun 15, 2020
@ghost ghost added the size/XXL label Jun 15, 2020
@gzussa gzussa removed the do-not-merge/WIP Do not merge this PR label Jun 18, 2020
therve
therve requested changes Jun 19, 2020
View reviewed changes
Copy link
Contributor

@therve therve left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great overall. Some minor indent issues, I didn't comment on all of them but it'd be nice to fix. There is lot of commented code too, it'd be nice to have comments explaining why, or to delete it.

datadog/provider_test.go Outdated Show resolved Hide resolved
datadog/provider_test.go Show resolved Hide resolved
datadog/resource_datadog_dashboard.go Show resolved Hide resolved
datadog/resource_datadog_dashboard_distribution_test.go Outdated Show resolved Hide resolved
datadog/resource_datadog_dashboard_distribution_test.go Outdated Show resolved Hide resolved
datadog/resource_datadog_dashboard_distribution_test.go Show resolved Hide resolved
datadog/resource_datadog_dashboard_alert_graph_test.go Outdated Show resolved Hide resolved
datadog/resource_datadog_dashboard_alert_value_test.go Outdated Show resolved Hide resolved
datadog/resource_datadog_dashboard_event_stream_test.go Outdated Show resolved Hide resolved
datadog/resource_datadog_dashboard_service_map_test.go Show resolved Hide resolved
jirikuncar
jirikuncar reviewed Jun 19, 2020
View reviewed changes
GNUmakefile Outdated Show resolved Hide resolved
gzussa and others added 4 commits June 19, 2020 10:37
@gzussa @therve
Update datadog/provider_test.go
b50a135 
Co-authored-by: Thomas Hervé <thomas.herve@datadoghq.com>
incorporate feedback
47ab23b
Merge branch 'gzu/dash_tests' of github.com:terraform-providers/terra…
cde8911 
…form-provider-datadog into gzu/dash_tests
incorporate feedback
181b7cc
@gzussa gzussa requested a review from therve June 19, 2020 10:56
@gzussa gzussa added the bug label Jun 19, 2020
@gzussa gzussa merged commit 61c9cbb into master Jun 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jirikuncar jirikuncar jirikuncar approved these changes

@therve therve Awaiting requested review from therve

Assignees
No one assigned
Labels
bug size/XXL
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gzussa @therve @jirikuncar