Sort datadog_downtime monitor tags to avoid plan diffs #540
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
gzussa
reviewed
Jun 19, 2020
jirikuncar
reviewed
Jul 15, 2020
datadog/resource_datadog_downtime.go
Outdated
| tags = append(tags, mt.(string)) | ||
| } | ||
| sort.Strings(tags) |
There was a problem hiding this comment.
do we still need to sort them if we are using schema.TypeSet [1] ?
--
[1] https://www.terraform.io/docs/extend/schemas/schema-types.html#typeset
jirikuncar
reviewed
Jul 16, 2020
jirikuncar
reviewed
Jul 16, 2020
jirikuncar
reviewed
Jul 16, 2020
|
Addresses #577 |
jirikuncar
approved these changes
Jul 17, 2020
therve
approved these changes
Jul 21, 2020
|
Thanks for cleaning it up @jirikuncar and merging 🥇 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Once an unsorted list of
monitor_tagsis applied fordatadog_downtime, Terraform shows a permanent diff because Datadog API responds with an ordered list.This PR builds on https://github.com/terraform-providers/terraform-provider-datadog/pull/214 by changing the type from list to set and applying ordering. I've extended the tests with additional values and replayed cassettes. The fix appears to work using a binary for my use case.