existing PD integration should not be deleted on create #564 #565
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
|
Looks like the test changes will require me to re-record the cassettes since the code change will add an additional GET request to the integration endpoint. I"ll do so later with a non-production organization, same for any new test cases |
skang0601
force-pushed
the
fix-pagerduty-integration
branch
from
78149f4
to
8453025
Compare
jirikuncar
reviewed
Jul 16, 2020
| @@ -150,7 +161,6 @@ func resourceDatadogIntegrationPagerdutyRead(d *schema.ResourceData, meta interf | |||
| d.Set("services", services) | |||
| d.Set("subdomain", pd.GetSubdomain()) | |||
| d.Set("schedules", pd.Schedules) | |||
|
|
|||
| return nil | |||
There was a problem hiding this comment.
Suggested change
| return nil | |
| return nil |
jirikuncar
reviewed
Jul 16, 2020
| @@ -112,6 +119,10 @@ func resourceDatadogIntegrationPagerdutyCreate(d *schema.ResourceData, meta inte | |||
| return fmt.Errorf("failed to parse resource configuration: %s", err.Error()) | |||
| } | |||
|
|
|||
| if exists, _ := resourceDatadogIntegrationPagerdutyExists(d, meta); exists && d.Get("preserve_existing_integration").(bool) { | |||
| return translateClientError(errors.New("PagerDuty integration already exists"), "Please import into your existing state or remove from your HCL.") | |||
There was a problem hiding this comment.
@skang0601 can you please add new test to cover this branch? Thank you!
|
We discussed another approach, thanks for your patch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addressed #564
Added a new optional field in the datadog_pagerduty_integration resource the maintain backwards compatibility with the old behavior but allows users to also prevent the resource from deleting the existing PagerDuty integration silently.
This seems like something that the API should handle by returning an appropriate error status code, but the provider should also follow conventions/expectations for Terraform users regarding resource creation/deletion.