Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Synthetics] Add options_list to replace options #624

Merged
merged 16 commits into from
Aug 14, 2020

Conversation

romainberger
Copy link
Member

No description provided.

@romainberger romainberger marked this pull request as ready for review August 5, 2020 13:31
@romainberger romainberger requested a review from a team as a code owner August 5, 2020 13:31
Type: schema.TypeList,
Optional: true,
MaxItems: 1,
ConflictsWith: []string{"options"},

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nth: As discussed earlier, we should add a test if ConflictsWith can raise an error

datadog/resource_datadog_synthetics_test_.go Show resolved Hide resolved
datadog/resource_datadog_synthetics_test_.go Outdated Show resolved Hide resolved
docs/resources/synthetics.md Outdated Show resolved Hide resolved
Copy link
Contributor

@therve therve left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Getting there, a few comments.

datadog/resource_datadog_synthetics_test_.go Show resolved Hide resolved
datadog/resource_datadog_synthetics_test_test.go Outdated Show resolved Hide resolved
docs/resources/synthetics.md Outdated Show resolved Hide resolved
docs/resources/synthetics.md Show resolved Hide resolved
@therve
Copy link
Contributor

therve commented Aug 14, 2020

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@therve
Copy link
Contributor

therve commented Aug 14, 2020

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

Copy link
Contributor

@therve therve left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One small doc problem, otherwise looks great.

docs/resources/synthetics.md Outdated Show resolved Hide resolved
docs/resources/synthetics.md Outdated Show resolved Hide resolved
docs/resources/synthetics.md Outdated Show resolved Hide resolved
…thub.com:DataDog/terraform-provider-datadog into rberger/SYA-181/synthetics-update-options-format
@therve therve merged commit f0ed251 into master Aug 14, 2020
@therve therve deleted the rberger/SYA-181/synthetics-update-options-format branch August 14, 2020 12:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants