Support multi_compute field in log_query #629
Conversation
This adds support for the `multi_compute` field alternative to the `compute` one. Closes #628
therve
changed the title
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
| @@ -4713,7 +4713,27 @@ func getApmLogNetworkRumSecurityQuerySchema() *schema.Schema { | |||
| }, | |||
| "compute": { | |||
There was a problem hiding this comment.
Since compute and multi_compute are mutually exclusive (as per the docs below), should we mark them with ConflictsWith? (see it's doc under https://godoc.org/github.com/hashicorp/terraform-plugin-sdk/helper/schema#Schema)
There was a problem hiding this comment.
Hmm, actually after re-reading this I'm not sure. Are they mutually exclusive or can they coexist?
There was a problem hiding this comment.
AFAIK you can't use ConflictsWith inside lists or maps.
There was a problem hiding this comment.
Ah, that's right. So we're basically relying on the API to return the proper error message if both are used, right?
There was a problem hiding this comment.
Yeah I added a TODO below, but I need to change 5 different functions to propagate errors :/
| Required: true, | ||
| Optional: true, | ||
| Elem: &schema.Resource{ | ||
| Schema: map[string]*schema.Schema{ |
There was a problem hiding this comment.
This Schema definition seems the same as the one for multi_compute AFAICS. Would it make sense to create a function to return it instead of duplicating it?
There was a problem hiding this comment.
We could. The schema for compute is actually useless because it's a TypeMap, but it doesn't hurt.
therve
force-pushed
the
therve/multi-compute
branch
from
dffb6f9
to
ef42256
Compare
This adds support for the
multi_computefield alternative to thecomputeone.Closes #628