Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add subtype TCP test support for Synthetics Api test #632

Merged
merged 7 commits into from
Aug 17, 2020

Conversation

skarimo
Copy link
Member

@skarimo skarimo commented Aug 12, 2020

This PR adds support for synthetics API test subtype TCP. Spec implementation: https://github.com/DataDog/datadog-api-spec/pull/479

@skarimo skarimo marked this pull request as ready for review August 12, 2020 21:30
@skarimo skarimo requested a review from a team as a code owner August 12, 2020 21:30
Copy link
Contributor

@therve therve left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, one minor comment.

therve
therve previously approved these changes Aug 14, 2020
@therve
Copy link
Contributor

therve commented Aug 14, 2020

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@therve
Copy link
Contributor

therve commented Aug 17, 2020

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@therve therve merged commit 17f132d into master Aug 17, 2020
@therve therve deleted the sherz/synthetics-tcp-subtest-support branch August 17, 2020 09:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants