Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add datadog_screenboard resource #91

Merged
merged 7 commits into from
Sep 7, 2018
Merged

Conversation

anatolebeuzon
Copy link
Contributor

@anatolebeuzon anatolebeuzon commented Sep 6, 2018

This PR adds full support for Datadog screenboards.
All 19 widgets are supported.

Solves #52.

@masci I suppose you should be the one reviewing this?

@ghost ghost added the size/XXL label Sep 6, 2018
Copy link
Contributor

@masci masci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One nit and one comment on docs, otherwise this PR is dope!

The code looks good but I've spent most of the time playing with the resource and it looks solid to me.

I'll release as soon as we merge this.

datadog/resource_datadog_screenboard.go Outdated Show resolved Hide resolved
website/docs/r/screenboard.html.markdown Outdated Show resolved Hide resolved
vendor/vendor.json Outdated Show resolved Hide resolved
@masci masci added this to the 1.3.0 milestone Sep 7, 2018
@ghost ghost added the size/XXL label Sep 7, 2018
@masci
Copy link
Contributor

masci commented Sep 7, 2018

Thanks @oxlay this was a long awaited feature from a lot of users! Merging now and releasing on Monday.

@masci masci merged commit da63ea0 into DataDog:master Sep 7, 2018
nitrocode pushed a commit to nitrocode/terraform-provider-datadog that referenced this pull request Nov 3, 2018
Add datadog_screenboard resource
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants