Apply empty statement suggestion

DataDog · Sep 13, 2024 · 949aeeb · 949aeeb
1 parent 5187b26
commit 949aeeb
Show file tree

Hide file tree

Showing 3 changed files with 18 additions and 10 deletions.
diff --git a/package.json b/package.json
@@ -31,7 +31,7 @@
   },
   "devDependencies": {
     "@types/jest": "^27.4.0",
-    "@types/node": "^18.11.18",
+    "@types/node": "^20",
     "@typescript-eslint/parser": "^5.48.2",
     "@vercel/ncc": "^0.36.1",
     "eslint": "^8.46.0",

diff --git a/src/__tests__/main.test.ts b/src/__tests__/main.test.ts
@@ -12,11 +12,9 @@ describe('Github Action', () => {
 
     test('with no api_key parameter', async () => {
       // Given
-      /* eslint-disable no-console */
-      const setFailedMock = jest.spyOn(core, 'setFailed').mockImplementation((message) => {
-        console.log(`Mocked setFailed called with message: ${message}`)
+      const setFailedMock = jest.spyOn(core, 'setFailed').mockImplementation(() => {
+        /* empty */
       })
-      /* eslint-enable no-console */
 
       // When
       await action.main()
@@ -28,11 +26,9 @@ describe('Github Action', () => {
     test('with no dsym_paths parameter', async () => {
       // Given
       jest.spyOn(core, 'getInput').mockImplementation(() => 'foo')
-      /* eslint-disable no-console */
-      const setFailedMock = jest.spyOn(core, 'setFailed').mockImplementation((message) => {
-        console.log(`Mocked setFailed called with message: ${message}`)
+      const setFailedMock = jest.spyOn(core, 'setFailed').mockImplementation(() => {
+        /* empty */
       })
-      /* eslint-enable no-console */
 
       // When
       await action.main()

diff --git a/yarn.lock b/yarn.lock
@@ -2191,7 +2191,7 @@
   resolved "https://registry.yarnpkg.com/@types/minimatch/-/minimatch-5.1.2.tgz#07508b45797cb81ec3f273011b054cd0755eddca"
   integrity sha512-K0VQKziLUWkVKiRVrx4a40iPaxTUefQmjtkQofBkYRcoaaL/8rhwDWww9qWbrgicNOgnpIsMxyNIUM4+n6dUIA==
 
-"@types/node@*", "@types/node@^18.11.18":
+"@types/node@*":
   version "18.11.18"
   resolved "https://registry.yarnpkg.com/@types/node/-/node-18.11.18.tgz#8dfb97f0da23c2293e554c5a50d61ef134d7697f"
   integrity sha512-DHQpWGjyQKSHj3ebjFI/wRKcqQcdR+MoFBygntYOZytCqNfkd2ZC4ARDJ2DQqhjH5p85Nnd3jhUJIXrszFX/JA==
@@ -2203,6 +2203,13 @@
   dependencies:
     undici-types "~5.26.4"
 
+"@types/node@^20":
+  version "20.16.5"
+  resolved "https://registry.yarnpkg.com/@types/node/-/node-20.16.5.tgz#d43c7f973b32ffdf9aa7bd4f80e1072310fd7a53"
+  integrity sha512-VwYCweNo3ERajwy0IUlqqcyZ8/A7Zwa9ZP3MnENWcB11AejO+tLy3pu850goUW2FC/IJMdZUfKpX/yxL1gymCA==
+  dependencies:
+    undici-types "~6.19.2"
+
 "@types/prettier@^2.1.5":
   version "2.7.2"
   resolved "https://registry.yarnpkg.com/@types/prettier/-/prettier-2.7.2.tgz#6c2324641cc4ba050a8c710b2b251b377581fbf0"
@@ -6812,6 +6819,11 @@ undici-types@~5.26.4:
   resolved "https://registry.yarnpkg.com/undici-types/-/undici-types-5.26.5.tgz#bcd539893d00b56e964fd2657a4866b221a65617"
   integrity sha512-JlCMO+ehdEIKqlFxk6IfVoAUVmgz7cU7zD/h9XZ0qzeosSHmUJVOzSQvvYSYWXkFXC+IfLKSIffhv0sVZup6pA==
 
+undici-types@~6.19.2:
+  version "6.19.8"
+  resolved "https://registry.yarnpkg.com/undici-types/-/undici-types-6.19.8.tgz#35111c9d1437ab83a7cdc0abae2f26d88eda0a02"
+  integrity sha512-ve2KP6f/JnbPBFyobGHuerC9g1FYGn/F8n1LWTwNxCEzd6IfqTwUQcNXgEtmmQ6DlRrC1hrSrBnCZPokRrDHjw==
+
 universalify@^0.1.0:
   version "0.1.2"
   resolved "https://registry.yarnpkg.com/universalify/-/universalify-0.1.2.tgz#b646f69be3942dabcecc9d6639c80dc105efaa66"