Sort keys returned by AllKeys in reverse order #34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
truthbk
approved these changes
May 20, 2024
| @@ -1801,9 +1802,20 @@ func (v *Viper) AllKeys() []string { | |||
| for x := range m { | |||
| a = append(a, x) | |||
| } | |||
| return a | |||
| sort.Strings(a) | |||
There was a problem hiding this comment.
Maybe a reverse order insert sort in the for loop above might make more sense, but since I don't presume this doesn't get called much, this should be fine.
jeremy-hanna
approved these changes
May 20, 2024
| @@ -1801,9 +1802,20 @@ func (v *Viper) AllKeys() []string { | |||
| for x := range m { | |||
| a = append(a, x) | |||
| } | |||
| return a | |||
| sort.Strings(a) | |||
| return ReverseStringSlice(a) | |||
There was a problem hiding this comment.
could we use sort.Reverse for this?
sort.Sort(sort.Reverse(sort.StringSlice(a)))
There was a problem hiding this comment.
No, unfortunately this repo requires 1.14, generics aren't available.
ogaca-dd
approved these changes
May 21, 2024
|
Abandoning this PR, in favor of this approach: #36 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Returning keys in a stable manner prevents non-determinism. A bug happening in
allSettingsmanifests under certain orders of keys, by using reverse order this bug is never triggered.