Feat: Pages and Simple Sections #2
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SlimDeluxe
requested changes
Aug 5, 2025
database/migrations/2025_07_22_082135_create_sections_table.php
Outdated
Show resolved
Hide resolved
SlimDeluxe
requested changes
Aug 8, 2025
SlimDeluxe
requested changes
Aug 13, 2025
There was a problem hiding this comment.
- There's an error when creating a new section
- Sections are not scoped to tenant? I can see the same sections on both sites.
- I don't know how but you missed the instruction to make sections as nav menu items. I even included a screenshot from the old app. But you checked as Done anyway.
- Same goes for tenant test, marked as Done but I can't see it.
Comment on lines
+51
to
+55
| /** @return BelongsTo<\Eclipse\Core\Models\Site, self> */ | ||
| public function site(): BelongsTo | ||
| { | ||
| return $this->belongsTo(\Eclipse\Core\Models\Site::class); | ||
| } |
There was a problem hiding this comment.
Again, this is problematic... Core is not a dep of this plugin, so Site should not be used.
|
Before continuing please merge from the main branch, I updated the CI workflows. |
|
@SlimDeluxe Wait it already has all the changes from the main branch I don't know what you mean by. "Merge from the main branch" |
|
@thapacodes4u your last commit in this PR was on 11th Aug, but I made a change to the CI files 2 days later. If you merge from main, you'll get the fixed workflows so that tests in the PR work. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Ticket