16c563b8966ad05c8c67450865cd26d7aa0436f5 Fix: Dropup wasn't working w…

…hen in an offset parent with a low position top https://datatables.net/forums/discussion/79861 Sync to source repo @16c563b8966ad05c8c67450865cd26d7aa0436f5
DataTables · Sep 18, 2024 · 253b8b6 · 253b8b6
1 parent 54b3af8
commit 253b8b6
Show file tree

Hide file tree

Showing 5 changed files with 5 additions and 5 deletions.
diff --git a/datatables.json b/datatables.json
@@ -25,5 +25,5 @@
  ],
  "src-repo": "http://github.com/DataTables/Buttons",
  "last-tag": "3.1.2",
- "last-sync": "e4bc9e36c967a8db99affbe39d9f1144b25b6769"
+ "last-sync": "16c563b8966ad05c8c67450865cd26d7aa0436f5"
 }
diff --git a/js/dataTables.buttons.js b/js/dataTables.buttons.js
@@ -1534,7 +1534,7 @@ $.extend(Buttons.prototype, {
  popoverSizes.marginBottom;
  }
 
- if (containerPosition.top + top < $(window).scrollTop()) {
+ if (offsetParent.offset().top + top < $(window).scrollTop()) {
  // Correction for when the top is beyond the top of the page
  top = buttonPosition.top + hostNode.outerHeight();
  }

diff --git a/js/dataTables.buttons.min.js b/js/dataTables.buttons.min.js
diff --git a/js/dataTables.buttons.min.mjs b/js/dataTables.buttons.min.mjs
diff --git a/js/dataTables.buttons.mjs b/js/dataTables.buttons.mjs
@@ -1494,7 +1494,7 @@ $.extend(Buttons.prototype, {
  popoverSizes.marginBottom;
  }
 
- if (containerPosition.top + top < $(window).scrollTop()) {
+ if (offsetParent.offset().top + top < $(window).scrollTop()) {
  // Correction for when the top is beyond the top of the page
  top = buttonPosition.top + hostNode.outerHeight();
  }