Fix ClientMount Columns + Add AllReady rollup #196
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The current ClientMount columns are not working. The Status.Mounts.Ready fields need to be rolled up into one status to get these to work. Signed-off-by: Blake Devcich <blake.devcich@hpe.com>
roehrich-hpe
approved these changes
Apr 22, 2024
ajfloeder
reviewed
Apr 22, 2024
| @@ -278,16 +278,8 @@ spec: | |||
| subresources: | |||
| status: {} | |||
| - additionalPrinterColumns: | |||
| - description: mounted/unmounted | |||
There was a problem hiding this comment.
Ready tells us something, but without the desired state we don't know if they are mounted or not. Don't you think we need these?
There was a problem hiding this comment.
I'll add that back. The current state is tricking since we'd need to roll that up, so that's why I took these out. But desired state is straight forward.
Signed-off-by: Blake Devcich <blake.devcich@hpe.com>
roehrich-hpe
approved these changes
Apr 23, 2024
ajfloeder
approved these changes
Apr 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current ClientMount columns are not working. The Status.Mounts.Ready fields need to be rolled up into one status to get these to work.