Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Included venv instructions and added venv/ to .gitignore #126

Merged
merged 1 commit into from
Mar 31, 2021

Conversation

shadow00
Copy link
Contributor

By default, running pip3 install -r requirements.txt outside of a virtual environment will install packages for the entire system. This is bad, since different projects may require conflicting versions of the same packages. The best practice is to use some kind of virtual environment (this feature typically comes preinstalled with most distributions, so all you really need to do is run a simple command to set it up) and install the packages inside that venv.

This also makes it much easier to contribute for anyone who's already familiar with using a venv.

Note that this PR will create a merge conflict with #125 because they both change the contents of the README.md file. I suggest merging this PR first, and then I'll rebase and force-push my config branch for the other PR - that way all you'll need to do is just merge them both.

@Datalux
Copy link
Owner

Datalux commented Mar 31, 2021

@shadow00 thank you very much for your work!
I had planned to add a virtual environment for this project but you preceded me by implementing all things.
I'm very happy!

@Datalux Datalux merged commit 7f558b1 into Datalux:development Mar 31, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants