Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DEV-14115 Make variable naming more consistent. #2

Merged
merged 4 commits into from
Nov 5, 2020
Merged

DEV-14115 Make variable naming more consistent. #2

merged 4 commits into from
Nov 5, 2020

Conversation

daniosim
Copy link
Contributor

@daniosim daniosim commented Nov 5, 2020 •
edited
Loading

https://datatamr.atlassian.net/browse/DEV-14115

Renamed

  • name -> instance_name for clarity
  • resource_group_location -> location for consistency across repos

souza-dan
souza-dan approved these changes Nov 5, 2020
View reviewed changes
Copy link
Contributor

@souza-dan souza-dan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@daniosim daniosim merged commit 5e47281 into master Nov 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@souza-dan souza-dan souza-dan approved these changes

@schwartzmanb schwartzmanb schwartzmanb approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@daniosim @schwartzmanb @souza-dan