Fix test changes workflow #94
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. output the HTTP error to make it easier to see what's happening 2. always output the NEW data, even in case of an HTTP error
|
exemplary output can be seen here: https://github.com/cyroxx/jedeschule-scraper/runs/1739162888?check_suite_focus=true#step:6:1 |
k-nut
approved these changes
Jan 21, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up to PR #61.
The previous PR had some issues:
git whatchangedfailed becauseactions/checkout@v2only checks out the latest commit by default. Fixed by settingfetch-depthto0in order to check out the full history. (In the unforeseeable future, there might be afetch-refsoption to optimize this, see revise adr to support fetch-refs actions/checkout#155)--overwrite-outputoption that is used intest_changes.shdatabase_pipeline.pycreated a session during load time, which complicates things when we do not actually need the DatabasePipeline. refactored session creation into theget_session()method to be more flexible here.@k-nut : Please take a closer look at the session management (6791182). I do have the feeling that our session handling could be improved (i, e. using a fewer number of opened sessions overall).
test_changes.py(!) so that its output is helpful in more cases