Add FSTileList and FSTileEntitiesList #669
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Updated FSTileDashboardsList, FSTileDeviceOrganisationsList, FSTileFoldersList, FSTileGroupsList, FSTileLocationsList, FSTileModelsList, and FSTileUserOrganisationsList components to support selectable and single-select functionalities. - Added modelValue prop to manage selected items across various tile lists. - Implemented corresponding storybook entries for each tile list to demonstrate selectable and single-select features.
There was a problem hiding this comment.
Pull request overview
This PR introduces a reusable tile list system with support for selection, search, and entity-specific implementations. The changes include a base FSTileList component, seven entity-specific tile list components, and a dynamic FSTileEntitiesList wrapper that switches between them based on entity type.
- Added
FSTileListcomponent with search, selection (single/multi), and loading states - Created entity-specific tile list components for devices, dashboards, folders, users, groups, locations, and models
- Enhanced
FSSimpleTileUIwith selectable functionality and v-model support - Updated lerna to version 9.0.0 and added OIDC permissions to GitHub workflow
Reviewed changes
Copilot reviewed 30 out of 31 changed files in this pull request and generated 7 comments.
Show a summary per file
| File | Description |
|---|---|
| FSSimpleTileUI.vue | Added selectable prop and update:modelValue emit for selection support |
| FSTileList.vue | New base component providing search, filtering, selection logic, and layout options |
| FSTileUserOrganisationsList.vue | Entity-specific wrapper for user organisations with data fetching |
| FSTileModelsList.vue | Entity-specific wrapper for models with data fetching |
| FSTileLocationsList.vue | Entity-specific wrapper for locations with data fetching |
| FSTileGroupsList.vue | Entity-specific wrapper for groups with data fetching |
| FSTileFoldersList.vue | Entity-specific wrapper for folders with data fetching |
| FSTileDeviceOrganisationsList.vue | Entity-specific wrapper for device organisations with data fetching |
| FSTileDashboardsList.vue | Entity-specific wrapper for dashboards aggregating three dashboard types |
| FSTileEntitiesList.vue | Dynamic component router that loads appropriate tile list based on entity type |
| package.json | Updated lerna dependency from 7.3.0 to 9.0.0 |
| publish-npm.yml | Added OIDC permissions for secure npm publishing |
| TileList.stories.ts | Storybook story demonstrating FSTileList usage with selection and custom props |
| TileUserOrganisationsList.stories.ts | Storybook stories for user organisations tile list variations |
| TileModelsList.stories.ts | Storybook stories for models tile list variations |
| TileLocationsList.stories.ts | Storybook stories for locations tile list variations |
| TileGroupsList.stories.ts | Storybook stories for groups tile list variations |
| TileFoldersList.stories.ts | Storybook stories for folders tile list variations |
| TileDeviceOrganisationsList.stories.ts | Storybook stories for device organisations tile list variations |
| TileDashboardsList.stories.ts | Storybook stories for dashboards tile list variations |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
src/core/foundation-core-components/components/entities/FSTileEntitiesList.vue
Outdated
Show resolved
Hide resolved
src/shared/foundation-shared-components/components/lists/FSTileList.vue
Outdated
Show resolved
Hide resolved
src/shared/foundation-shared-components/components/lists/FSTileList.vue
Outdated
Show resolved
Hide resolved
src/core/foundation-core-components/components/lists/dashboards/FSTileDashboardsList.vue
Outdated
Show resolved
Hide resolved
src/core/foundation-core-components/components/entities/FSTileEntitiesList.vue
Outdated
Show resolved
Hide resolved
src/core/foundation-core-components/components/entities/FSTileEntitiesList.vue
Outdated
Show resolved
Hide resolved
peyronth
reviewed
Dec 11, 2025
src/shared/foundation-shared-components/components/lists/FSTileList.vue
Outdated
Show resolved
Hide resolved
src/shared/foundation-shared-components/components/lists/FSTileList.vue
Outdated
Show resolved
Hide resolved
src/shared/foundation-shared-components/components/lists/FSTileList.vue
Outdated
Show resolved
Hide resolved
src/shared/foundation-shared-components/components/tiles/FSSimpleTileUI.vue
Outdated
Show resolved
Hide resolved
...oundation-core-components/components/lists/userOrganisations/FSTileUserOrganisationsList.vue
Show resolved
Hide resolved
gballigand
reviewed
Dec 12, 2025
src/core/foundation-core-components/components/lists/models/FSTileModelsList.vue
Show resolved
Hide resolved
| :imageId="item.imageId" | ||
| :label="item.label" | ||
| :code="item.code" | ||
| :width="direction === 'column' ? 'fill' : undefined" |
Contributor
There was a problem hiding this comment.
On a pas mieux que undefined ? (valable pour toutes les listes)
Contributor
Author
There was a problem hiding this comment.
Si je mets null, cela casse la width le tuile. Cela ne prends pas en compte la valeur par défaut.
Contributor
There was a problem hiding this comment.
undefined c'est vraiment ce qu'on veut car ce qu'on veut c'es prendr ela taille par défaut de la tuile
peyronth
reviewed
Dec 12, 2025
src/core/foundation-core-components/components/lists/dashboards/FSTileDashboardsList.vue
Outdated
Show resolved
Hide resolved
| :imageId="item.imageId" | ||
| :label="item.label" | ||
| :code="item.code" | ||
| :width="direction === 'column' ? 'fill' : undefined" |
Contributor
There was a problem hiding this comment.
undefined c'est vraiment ce qu'on veut car ce qu'on veut c'es prendr ela taille par défaut de la tuile
src/shared/foundation-shared-components/components/lists/FSTileList.vue
Outdated
Show resolved
Hide resolved
...oundation-core-components/components/lists/userOrganisations/FSTileUserOrganisationsList.vue
Outdated
Show resolved
Hide resolved
peyronth
approved these changes
Dec 18, 2025
gballigand
approved these changes
Dec 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.