Reformatting code #29
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FSMaxB
commented
Sep 28, 2016
| { | ||
| /* three bytes, encoding 1110xxxx 10xxxxxx 10xxxxxx */ | ||
| len = 3; | ||
| ptr2 += len; |
There was a problem hiding this comment.
Oh, that looks like I introduced a bug here.
|
When I'm done, I need to find a way to compare the code before and after formatting if it is identical. I already found one bug I introduced, so I need to ensure there aren't more. |
|
Maybe I can just compile it (without machine code) and diff the assembly. |
FSMaxB
force-pushed
the
reformatting
branch
2 times, most recently
from
e92d73f to
949ff0d
Compare
|
Compiling to assembly and doing a diff works perfectly and I found another bug that way. |
|
@DaveGamble: If there's no objection you can merge it. |
|
I rebased this branch on top of the new fix for #30 . |
|
Given the time that passed where people had time to complain, I'll merge this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a work in progressof reformatting the code, see #24.Not ready for merging yet.