Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Fix versioning in package deployment (v3) #1305

Draft
wants to merge 52 commits into
base: v3
Choose a base branch
from
Draft

Conversation

DaveSkender
Copy link
Owner

@DaveSkender DaveSkender commented Dec 30, 2024

Important

Don't merge here, this is just for troubleshooting v3 preview increments. Move to:

Ref: GitVersion configuration and variables docs

  • try again with built-in tasks. the error was I was using -c instead of -config for path
  • conditionally use prerelease gitversion variable
  • fix: load GitVersion vars to env
  • review workflow: GitHubFlow/v1
  • ensure NO_ENVIRONMENT is not created, or use “”

@DaveSkender DaveSkender self-assigned this Dec 30, 2024
@DaveSkender DaveSkender changed the title Fix deployer ci: Fix versioning in package deployment (v3) Dec 30, 2024
@DaveSkender DaveSkender mentioned this pull request Dec 30, 2024
3 tasks
@DaveSkender DaveSkender requested a review from Copilot December 30, 2024 05:29

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 3 out of 4 changed files in this pull request and generated no comments.

Files not reviewed (1)
  • .vscode/settings.json: Language not supported
@DaveSkender
Copy link
Owner Author

DaveSkender commented Dec 30, 2024

Steps to add locally:

  1. Install tool from repo folder (can also install globally)
    dotnet new tool-manifest
    dotnet tool install GitVersion.Tool --version 6.0.5
  2. Show configuration
    # both of these work
    dotnet-gitversion -c src/gitversion.yml -showconfig
    dotnet gitversion -c src/gitversion.yml -showconfig
  3. Run diagnostics
    dotnet gitversion -diag -config src/gitversion.yml

Signed-off-by: Dave Skender <8432125+DaveSkender@users.noreply.github.com>
Signed-off-by: Dave Skender <8432125+DaveSkender@users.noreply.github.com>
Signed-off-by: Dave Skender <8432125+DaveSkender@users.noreply.github.com>
Signed-off-by: Dave Skender <8432125+DaveSkender@users.noreply.github.com>
Signed-off-by: Dave Skender <8432125+DaveSkender@users.noreply.github.com>
Signed-off-by: Dave Skender <8432125+DaveSkender@users.noreply.github.com>
Signed-off-by: Dave Skender <8432125+DaveSkender@users.noreply.github.com>
Signed-off-by: Dave Skender <8432125+DaveSkender@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: In Progress
Development

Successfully merging this pull request may close these issues.

1 participant