Implement embedded-io traits for Usart #111
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akhilles
force-pushed
the
embedded-io
branch
from
f1fb5b3 to
8bc16f8
Compare
|
Looking good; I'll test it at some point. |
|
Is this ready for revie? |
|
Yup, good to review |
This is gated by the embedded-hal feature. Tested on an STM32H747. Signed-off-by: Akhil Velagapudi <4@4khil.com>
Better to fail fast. Signed-off-by: Akhil Velagapudi <4@4khil.com>
Makes it easier to use generic Usart impls because BaudPeriph and RccPeriph are private traits. Signed-off-by: Akhil Velagapudi <4@4khil.com>
G4, H7, etc. require explicitly clearing the error flags from the ICR register. Signed-off-by: Akhil Velagapudi <4@4khil.com>
|
Discovered an issue with more testing where error states weren't being cleared reliably. Turns out on newer families you have to explicitly clear error states from the ICR register. Fixed in ec26a71. I've been testing quite a bit on the H7, but not other families. |
|
Nice |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is gated by the embedded-hal feature. Tested on an STM32H747.