Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added avc,prk and 4k profiles #7

Merged
merged 13 commits into from
Mar 24, 2024

Conversation

erickyun
Copy link
Contributor

No description provided.

@DavidBuchanan314
Copy link
Owner

Hi, thanks for the contribution!

I don't have time to test it myself right now, but if you can tell me which browser(s) and platforms you've tested it on, I'm willing to take your word for it and merge

@erickyun
Copy link
Contributor Author

erickyun commented Mar 23, 2024

Hi, thanks for the contribution!

I don't have time to test it myself right now, but if you can tell me which browser(s) and platforms you've tested it on, I'm willing to take your word for it and merge

Tested on Windows 11 Edge browser sir.
Btw I appreciate your great work, and thank you for this repo. 🙂👍

@DavidBuchanan314 DavidBuchanan314 merged commit 005a106 into DavidBuchanan314:master Mar 24, 2024
@DavidBuchanan314
Copy link
Owner

ty!

@kadrim
Copy link

kadrim commented Mar 24, 2024

sorry to step in, but this addition broke playback in firefox. in edge it's working fine, but FF refuses to playback videos at all

error code f7355-1203

OS: Windows 11

@DavidBuchanan314
Copy link
Owner

Oop, I thought that might happen. Try fiddling with the config options

DavidBuchanan314 added a commit that referenced this pull request Mar 24, 2024
@DavidBuchanan314
Copy link
Owner

Rolled back for now

DavidBuchanan314 added a commit that referenced this pull request Mar 24, 2024
@erickyun
Copy link
Contributor Author

erickyun commented Mar 30, 2024

sorry to step in, but this addition broke playback in firefox. in edge it's working fine, but FF refuses to playback videos at all

error code f7355-1203

OS: Windows 11

As @DavidBuchanan314 said try changing config options from true to false and vice versa also
firefox&chrome do only support 720p acoording to this NF article right?
So according to this article avc,prk wouldn't work if it is set to "true" for firefox. And that
would also be the reason your browser gives an error code?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants