[CT-756] Stringify user-provided messages to {{ log() }} #1
Conversation
| @@ -43,7 +43,7 @@ def test__override_vars_global(self, project): | |||
|
|
|||
|
|
|||
| # This one switches to setting a var in 'test' | |||
| class TestCLIVarOverridePorject: | |||
| class TestCLIVarOverrideProject: | |||
There was a problem hiding this comment.
This is a completely unrelated change to fix this typo. I'm curious what the culture is about bundling in tiny unrelated changes like this. Is it fine or is it expected to be broken out to a separate PR?
| try: | ||
| msg = str(msg) | ||
| except Exception as e: | ||
| raise RuntimeException("log failed to stringify the given object") from e |
There was a problem hiding this comment.
Did a one-off test for this, since I can't think of a convenient way to induce this within the test case via jinja provided input (given dbt/jinja design, I'd sort of hope not 😆)
| @@ -0,0 +1,55 @@ | |||
| import pytest | |||
There was a problem hiding this comment.
Not sure if this is even the appropriate variation of test for this part of the codebase, I found this directory through randomly wandering, and then I copied adjacent files to get it to work.
| @@ -11,6 +11,7 @@ | |||
| from dbt.exceptions import ( | |||
| CompilationException, | |||
| MacroReturn, | |||
| RuntimeException, | |||
There was a problem hiding this comment.
Is there a more specific/appropriate exception than RuntimeException?
| @@ -543,10 +544,11 @@ def zip_strict(*args: Iterable[Any]) -> Iterable[Any]: | |||
|
|
|||
| @contextmember | |||
| @staticmethod | |||
| def log(msg: str, info: bool = False) -> str: | |||
| def log(msg: Any, info: bool = False) -> str: | |||
There was a problem hiding this comment.
TODO: figure out / what is the workflow to get https://github.com/dbt-labs/docs.getdbt.com/blob/current/website/docs/reference/dbt-jinja-functions/log.md get updated from this?
DavidMah
force-pushed
the
dmah/ct-756-log-str
branch
from
d2bf298 to
eef4cb0
Compare
draft: I'm using this rather randomly selected task to explore the workflow of contributing to dbt-core
TODO: get CLA through figma legal
TODO: post PR against actual repo
TODO: the changie thing
resolves dbt-labs#5385
Description
Much more depth in the issue dbt-labs#5385. This PR fixes an issue wherein
logerrors in the scenario that{{ log(["this is something other than a string"]) }}This PR implements the solution articulated in the issue and throws in a test case too.
Checklist
changie newto create a changelog entry