#193 Theme added(Winter) #207
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
terrifricker
reviewed
Oct 9, 2020
index.html
Outdated
| @@ -40,6 +40,8 @@ <h3>Home</h3> | |||
| <a class="dropdown-item" href="#" id="summerdayTheme">Summer Day Theme</a> | |||
| <a class="dropdown-item" href="#" id="pumpkinSpiceTheme">Pumpkin Fall Theme</a> | |||
| <a class="dropdown-item" href="#" id="abyssTheme">Abyss Theme</a> | |||
| <a class="dropdown-item" href="#" id="winterTheme">winter Theme</a> | |||
There was a problem hiding this comment.
Capitalize Winter in the dropdown menu to keep capitalization consistent with other items in the menu ...
Suggested change
| <a class="dropdown-item" href="#" id="winterTheme">winter Theme</a> | |
| <a class="dropdown-item" href="#" id="winterTheme">Winter Theme</a> |
|
Thank you for the new theme. The colors are great for a Winter theme. |
terrifricker
requested changes
Oct 9, 2020
There was a problem hiding this comment.
You've made good color choices to represent Winter. I like that they are so cool-colored. I would like to request one change:
In the index.html file, please capitalize Winter in the drop menu link. I've marked the spot in the file here in the pull request.
Thank you!
|
Thank you for pointing the changes, I just didn't notice it. I will make the change asap. |
terrifricker
added
the
hacktoberfest-accepted
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.