Basic wheel building support #55
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These are the code changes mentioned in #54, as well as fixing the dependency list in `setup.py` to match `requirements.txt`. With this, a wheel can be built like so: ``` $ python3 -m venv .venv $ .venv/bin/pip install -r dev-requirements.txt $ .venv/bin/python setup.py sdist bdist_wheel ```
|
I had to remove the pegged wheel version because of 3.4 compatibility. I also added test builds against 3.7 and 3.8. |
DavidMuller
added a commit
that referenced
this pull request
May 27, 2020
DavidMuller
reviewed
May 27, 2020
| @@ -10,7 +10,10 @@ | |||
| url='https://github.com/davidmuller/aws-requests-auth', | |||
| description='AWS signature version 4 signing process for the python requests module', | |||
| long_description='See https://github.com/davidmuller/aws-requests-auth for installation and usage instructions.', | |||
| install_requires=['requests>=0.14.0'], | |||
| install_requires=[ | |||
| 'botocore>=1.7.8', | |||
There was a problem hiding this comment.
It's a bit odd, but we don't require botocore as a strict dependency of the was-requests-auth:
DavidMuller
reviewed
May 27, 2020
| @@ -1,3 +1,2 @@ | |||
| mock==1.3.0 | |||
| requests==2.20.0 | |||
There was a problem hiding this comment.
right now requirements.txt is just for people developing new features aws_requests_auth - it is not involved in the setup.py / package publishing component of the repo (although I imagine an argument could be made that it "should be").
Since aws-requests-auth is not under active development, #56 ("Prep for wheel support on pypi") excludes this change
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These are the code changes mentioned in #54, as well as fixing the dependency list in
setup.pyto matchrequirements.txt.With this, a wheel can be built like so: