refactor: rename DealUpdateFlow to EntityUpdateFlow

DavidRouyer · Feb 13, 2021 · ed918da · ed918da
1 parent b7c5690
commit ed918da
Show file tree

Hide file tree

Showing 8 changed files with 12 additions and 12 deletions.
diff --git a/src/Pipedrive.net.Tests/Clients/DealsClientTests.cs b/src/Pipedrive.net.Tests/Clients/DealsClientTests.cs
@@ -297,7 +297,7 @@ public async Task RequestsCorrectUrl()
 
                 Received.InOrder(async () =>
                 {
-                    await connection.GetAll<DealUpdateFlow>(
+                    await connection.GetAll<EntityUpdateFlow>(
                         Arg.Is<Uri>(u => u.ToString() == "deals/123/flow"),
                         Arg.Is<Dictionary<string, string>>(d => d.Count == 1
                             && d["id"] == "123"),

diff --git a/src/Pipedrive.net.Tests/Clients/OrganizationsClientTests.cs b/src/Pipedrive.net.Tests/Clients/OrganizationsClientTests.cs
@@ -449,7 +449,7 @@ public async Task RequestsCorrectUrl()
 
                 Received.InOrder(async () =>
                 {
-                    await connection.GetAll<DealUpdateFlow>(
+                    await connection.GetAll<EntityUpdateFlow>(
                         Arg.Is<Uri>(u => u.ToString() == "organizations/123/flow"),
                         Arg.Is<Dictionary<string, string>>(d => d.Count == 1
                             && d["id"] == "123"),

diff --git a/src/Pipedrive.net/Clients/DealsClient.cs b/src/Pipedrive.net/Clients/DealsClient.cs
@@ -117,7 +117,7 @@ public Task Delete(long id)
             return ApiConnection.Delete(ApiUrls.Deal(id));
         }
 
-        public Task<IReadOnlyList<DealUpdateFlow>> GetUpdates(long dealId, DealUpdateFilters filters)
+        public Task<IReadOnlyList<EntityUpdateFlow>> GetUpdates(long dealId, DealUpdateFilters filters)
         {
             Ensure.ArgumentNotNull(filters, nameof(filters));
 
@@ -130,7 +130,7 @@ public Task<IReadOnlyList<DealUpdateFlow>> GetUpdates(long dealId, DealUpdateFil
                 PageSize = filters.PageSize
             };
 
-            return ApiConnection.GetAll<DealUpdateFlow>(ApiUrls.DealUpdates(dealId), parameters, options);
+            return ApiConnection.GetAll<EntityUpdateFlow>(ApiUrls.DealUpdates(dealId), parameters, options);
         }
 
         public Task<IReadOnlyList<DealFollower>> GetFollowers(long dealId)

diff --git a/src/Pipedrive.net/Clients/IDealsClient.cs b/src/Pipedrive.net/Clients/IDealsClient.cs
@@ -26,7 +26,7 @@ public interface IDealsClient
 
         Task Delete(long id);
 
-        Task<IReadOnlyList<DealUpdateFlow>> GetUpdates(long dealId, DealUpdateFilters filters);
+        Task<IReadOnlyList<EntityUpdateFlow>> GetUpdates(long dealId, DealUpdateFilters filters);
 
         Task<IReadOnlyList<DealFollower>> GetFollowers(long dealId);
 

diff --git a/src/Pipedrive.net/Clients/IOrganizationsClient.cs b/src/Pipedrive.net/Clients/IOrganizationsClient.cs
@@ -38,6 +38,6 @@ public interface IOrganizationsClient
 
         Task<IReadOnlyList<File>> GetFiles(long id, OrganizationFileFilters filters);
 
-        Task<IReadOnlyList<DealUpdateFlow>> GetUpdates(long dealId, OrganizationUpdateFilters filters);
+        Task<IReadOnlyList<EntityUpdateFlow>> GetUpdates(long dealId, OrganizationUpdateFilters filters);
     }
 }
diff --git a/src/Pipedrive.net/Clients/OrganizationsClient.cs b/src/Pipedrive.net/Clients/OrganizationsClient.cs
@@ -186,7 +186,7 @@ public Task<IReadOnlyList<File>> GetFiles(long id, OrganizationFileFilters filte
             return ApiConnection.GetAll<File>(ApiUrls.OrganizationFiles(id), parameters, options);
         }
 
-        public Task<IReadOnlyList<DealUpdateFlow>> GetUpdates(long id, OrganizationUpdateFilters filters)
+        public Task<IReadOnlyList<EntityUpdateFlow>> GetUpdates(long id, OrganizationUpdateFilters filters)
         {
             Ensure.ArgumentNotNull(filters, nameof(filters));
 
@@ -199,7 +199,7 @@ public Task<IReadOnlyList<DealUpdateFlow>> GetUpdates(long id, OrganizationUpdat
                 PageSize = filters.PageSize
             };
 
-            return ApiConnection.GetAll<DealUpdateFlow>(ApiUrls.OrganizationUpdates(id), parameters, options);
+            return ApiConnection.GetAll<EntityUpdateFlow>(ApiUrls.OrganizationUpdates(id), parameters, options);
         }
     }
 }
diff --git a/...ive.net/Converters/DealUpdateConverter.cs → ...e.net/Converters/EntityUpdateConverter.cs b/...ive.net/Converters/DealUpdateConverter.cs → ...e.net/Converters/EntityUpdateConverter.cs
@@ -5,7 +5,7 @@
 
 namespace Pipedrive.Internal
 {
-    public class DealUpdateConverter : JsonConverter
+    public class EntityUpdateConverter : JsonConverter
     {
         public override bool CanConvert(Type objectType)
         {
@@ -47,7 +47,7 @@ public override object ReadJson(JsonReader reader, Type objectType, object exist
                 }
             }
 
-            DealUpdateFlow model = (DealUpdateFlow)Activator.CreateInstance(objectType);
+            EntityUpdateFlow model = (EntityUpdateFlow)Activator.CreateInstance(objectType);
             serializer.Populate(jObject.CreateReader(), model);
             model.Data = dealUpdateEntity;
 

diff --git a/...t/Models/Response/Deals/DealUpdateFlow.cs → ...e.net/Models/Response/EntityUpdateFlow.cs b/...t/Models/Response/Deals/DealUpdateFlow.cs → ...e.net/Models/Response/EntityUpdateFlow.cs
@@ -4,8 +4,8 @@
 
 namespace Pipedrive
 {
-    [JsonConverter(typeof(DealUpdateConverter))]
-    public class DealUpdateFlow
+    [JsonConverter(typeof(EntityUpdateConverter))]
+    public class EntityUpdateFlow
     {
         [JsonProperty("object")]
         public string Object { get; set; }