Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make DealField OrderNr nullable #139

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

kardoaw
Copy link

@kardoaw kardoaw commented Dec 16, 2022

Hi!

Pipedrive API documentation does not seem to state that explicitly, but I am experiencing that a deal field's order nr can also be null.

@NChampion
Copy link

NChampion commented Dec 23, 2022

I've started running into this as well. The API must've returned 0 instead of null directly up until a few weeks ago. The problem seems to stem from sub-fields created based on the field type. We have custom monetary and address "deal" fields that generated sub-fields with no direct ID. They have a parent_id but their id, order_nr and a majority of their attributes are null.

The problematic sub-fields:

address

  • Apartment/suite no
  • House number
  • Street/road name
  • District/sublocality
  • City/town/village/locality
  • State/county
  • Region
  • Country
  • ZIP/Postal code
  • Full/combined address

monetary

  • Currency
  • Currency of [Fieldname]

@gregarican
Copy link
Contributor

It's more than just this one field. Other Boolean and DateTime field values are passed back in the Pipedrive API response as being null.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants