Fleshing out a few things. #62
Conversation
… are exposed and accessible. The Activity DueDate didn't seem to parse as expected from the JSON response, so changed the data type to string. The CustomFieldConverter likely needs to be changed back on my commit to reference the new LongCustomField class, rather than the previous IntCustomField class.
…alues rather than IntCustomField values.
| @@ -0,0 +1,298 @@ | |||
| using System; | |||
There was a problem hiding this comment.
What is that file for? Please remove it
| @@ -0,0 +1,47 @@ | |||
| using System; | |||
There was a problem hiding this comment.
What is that file for? Please remove it
| @@ -0,0 +1,59 @@ | |||
| using System; | |||
There was a problem hiding this comment.
What is that file for? Please remove it
| @@ -0,0 +1,67 @@ | |||
| using System; | |||
There was a problem hiding this comment.
What is that file for? Please remove it
| @@ -0,0 +1,132 @@ | |||
| using System; | |||
There was a problem hiding this comment.
What is that file for? Please remove it
| @@ -27,7 +27,7 @@ public class Activity : IDealUpdateEntity | |||
| public string ReferenceId { get; set; } | |||
|
|
|||
| [JsonProperty("due_date")] | |||
| public DateTime? DueDate { get; set; } | |||
| public string DueDate { get; set; } | |||
There was a problem hiding this comment.
Open a specific issue for that. I'll take a look, don't change that here.
There was a problem hiding this comment.
Okay. Should I at least place a comment block here referencing the possible issue?
| @@ -27,7 +27,7 @@ public class DealActivity | |||
| public string ReferenceId { get; set; } | |||
|
|
|||
| [JsonProperty("due_date")] | |||
| public DateTime? DueDate { get; set; } | |||
| public string DueDate { get; set; } | |||
There was a problem hiding this comment.
Open a specific issue for that. I'll take a look, don't change that here.
There was a problem hiding this comment.
Okay. Should I at least place a comment block here referencing the possible issue?
| [JsonProperty("done")] | ||
| public ActivityDone Done { get; set; } | ||
|
|
||
| [JsonProperty("type")] | ||
| public string Type { get; set; } | ||
|
|
||
| [JsonProperty("due_date")] | ||
| [JsonConverter(typeof(DateWithoutTimeConverter))] | ||
| public DateTime? DueDate { get; set; } | ||
| public string DueDate { get; set; } |
There was a problem hiding this comment.
Open a specific issue for that. I'll take a look, don't change that here.
There was a problem hiding this comment.
Okay. Should I at least place a comment block here referencing the possible issue?
| @@ -0,0 +1,13 @@ | |||
| namespace Pipedrive.CustomFields | |||
There was a problem hiding this comment.
This type has been replaced with LongCustomField, no need to recreate it.
There was a problem hiding this comment.
Okay, I will remove this file since it's no longer needed.
| writer.WritePropertyName(field.Key); | ||
| writer.WriteValue(s.Value); | ||
| break; | ||
| case IntCustomField i: |
There was a problem hiding this comment.
Don't override my work. I've replaced IntCustomField with LongCustomField in 2c50bfd
There was a problem hiding this comment.
My apologies, as I forgot to include that update in this particular file.
|
I have made the necessary changes that were requested. Should I close this pull request and create a new one with my updated code? |
|
You can update this one or create a new one! |
|
The latest commit from my fork should contain the requested changes. Hope this helps! |
|
Please remove the |
|
Will do. I was using v0.1.10.0 so perhaps that was why the DueDate handling was different. |
|
If you have a fork, sync it with my master branch and make changes from there, it will be simpler |
|
Hopefully this will be the last commit. Sorry for the confusion. Your last set of requested changes have been made. If this suits what's needed then we are good to go! |
Added a few API endpoint properties that were missing. A few DueDate fields changed to string data types, since the JSON response body wasn't properly parsing them as DateTime? elements. Added logic to the CustomFieldConverter class for instances where there are no custom fields defined.