-
-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create toml for blocks #6
Conversation
This is to store the dependencies of specific block. Based on Polylith and their tool on Clojure, there is dependencies definition for components and bases.
Warning: I did not test (yet) if everything still work. |
Thank you for this pull request @sharky98! If I understand it correctly, a |
Like I said I didn't test anything yet. Also, with the current version of the plugin, poetry does not seems to recognize the However, your Multiproject plugin should do the trick of running the build inside either bases or components with the But I think a better idea would be to have a simple generic wrapper over poetry (inside the multi plugin?). This wrapper could list in the |
I think this might be a feature considered in the future. Today, I would like to let the official Poetry tool do the actual building (because it does that very well), and just help it out with the current limitations of it (not being able to reference dependencies outside of a project hiearchy). So I'm leaning on letting the actual project define external dependencies. That's the way the Clojure Polylith tool did until recently. I hope the developers of Poetry will like my current PR that will add the possibility of workspaces in a natural way (so I can archive the multiproject plugin). |
I am currently working on a way to make the dependencies experience better, and am trying out a different path than the one suggested in this Pull Request. I like your approach very much even if it is not complete and fully working, and I also like that it is much like the Clojure implementation. I have been inspired by your work and will hopefully release a new command that will make dependency management across projects visual and a smooth experience. Thank you for contributing to this project, it is very appreciated! ⭐ |
pyproject.toml
might be needed for the blocks to define the deps. Polylith does so with its own tool.